Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashing to secp256k1 #863

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Add hashing to secp256k1 #863

wants to merge 20 commits into from

Conversation

skaunov
Copy link

@skaunov skaunov commented Nov 4, 2024

This PR is draft since I need a hint! When hashing the lib checks that the isogenous generator maps correctly onto the target curve generator. The problem is I couldn't find the relevant generator for RFC9380 yet (via a reference, or computationally). I found out that there's a path via the isogeny kernel, but I wonder if somebody could suggest a simpler way to obtain that to continue with this.

Description

Adds hashing to the <curves/secp256k1>.

closes: none - just a development


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master): applicable, but I guess it will go smoother when v0.5 will be merged into master
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work. The design of this development is very straightforward,
  • Wrote unit tests: partly
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md: feels like a bad idea until v0.5 is merged into master
  • Re-reviewed Files changed in the GitHub PR explorer

@skaunov skaunov changed the title secp256k1_XMD:SHA-256_SSWU_RO_ missing the isogenous generator Add hashing to secp256k1 Nov 7, 2024
@skaunov skaunov marked this pull request as ready for review November 7, 2024 05:17
@skaunov skaunov requested review from a team as code owners November 7, 2024 05:17
@skaunov skaunov requested review from z-tech, weikengchen and tyshko-rostyslav and removed request for a team November 7, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants