Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Config migration】regexManager -> customManager #12

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

namachan10777
Copy link
Collaborator

regexManagersではなくcustomManagersが現在の推奨の設定なので、そちらにマイグレーションを行います。

#11 とは独立です。

@namachan10777 namachan10777 self-assigned this Feb 16, 2024
@namachan10777 namachan10777 requested a review from sksat as a code owner February 16, 2024 09:29
Copy link
Member

@sksat sksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一応: ドキュメントへのリンクを貼ってくれませんか?あと,PR title をもう少し丁寧にしてほしいです(これでやってしまうと既存の設定への変更はすべて Config migration になる)

@namachan10777 namachan10777 changed the title Config migration 【Config migration】regexManager -> customManager Feb 21, 2024
@namachan10777
Copy link
Collaborator Author

ちょっと雑過ぎました。

regexManagerからcustomManagerへとrenovate本体がmigrateしたリリースが 36.107.0 です。このPRはそれへの対応です

@namachan10777
Copy link
Collaborator Author

namachan10777 commented Feb 22, 2024

rebaseした上でmergeします

@namachan10777 namachan10777 merged commit 0bb4396 into main Feb 22, 2024
2 checks passed
@namachan10777 namachan10777 deleted the chore/migrate-condig branch February 22, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants