Invoke wasm-pack in wasm crate build script to package wasm into $OUT_DIR #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
wasm-opslang
crate をcargo build
したら内部でwasm-pack build
するようにする変更の意図や背景
wasm-pack
のビルド生成物を Cargo のパッケージ管理に載せるためdevtools-frontend
のみを Cargo のパッケージ管理に載せていると、cargo package
できなくなる(Ignore copy target dir to handle cargo package #112 )build.rs
内にwasm-pack
相当の処理を載せることはできない(build.rs usage? rustwasm/wasm-pack#251 )$TARGET
がwasm32
でないときにbuild.rs
内部でwasm-pack
を呼び出してビルドするwasm-opslang
では何も問題なくできるcfg
で対応可能package.links
を用いて、dependents crate (のbuild.rs
)に$OUT_DIR
を渡す発端となる Issue