Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools-frontend/crates is Cargo workspace #126

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented Apr 18, 2024

概要

SSIA

変更の意図や背景

devtools-frontend/crates は Cargo workspace なので、Cargo.lock を commit します。また、リポジトリの gitignore を修正します。

発端となる Issue

@sksat sksat self-assigned this Apr 18, 2024
@sksat sksat requested a review from KOBA789 as a code owner April 18, 2024 11:06
@sksat
Copy link
Member Author

sksat commented Apr 18, 2024

rebase

@sksat sksat force-pushed the frontend-crates-is-cargo-workspace branch from 75c9ff1 to 27a5ac5 Compare April 18, 2024 11:07
@KOBA789 KOBA789 added this to the v0.7.0 milestone Apr 18, 2024
@KOBA789 KOBA789 added the invalid This doesn't seem right label Apr 18, 2024
Copy link
Member

@KOBA789 KOBA789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マージします

@KOBA789 KOBA789 merged commit 4d1a790 into main Apr 18, 2024
4 checks passed
@KOBA789 KOBA789 deleted the frontend-crates-is-cargo-workspace branch April 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants