Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup NodeJS 21 in Rust workflows for integrated frontend build #120

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented Mar 19, 2024

概要

SSIA

変更の意図や背景

Rust 向けの workflow においても,tmtc-c2acargo build 内で devtools-frontend のビルドが行われるため,NodeJS のセットアップをしておく必要がある.
setup-node をせずともデフォルトで NodeJS 18 が使えるが,devtools-frontend では NodeJS 21 を期待しており,warning が出る.
この修正は cargo clippycargo test, cargo doc などを行う分にはそこまで必要ではないが,NodeJS のバージョン起因の問題があった際に調査を容易にするため,また,Release workflow においては,実際に配布するバイナリのビルドを行う workflow であるため,統一して想定されている NodeJS 21 のセットアップを行う.

発端となる Issue

N/A

@sksat sksat added the invalid This doesn't seem right label Mar 19, 2024
@sksat sksat self-assigned this Mar 19, 2024
@sksat sksat requested a review from KOBA789 as a code owner March 19, 2024 09:10
Copy link
Member

@KOBA789 KOBA789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOU ARE RIGHT

@KOBA789 KOBA789 merged commit 8a1bf55 into main Mar 20, 2024
5 checks passed
@KOBA789 KOBA789 deleted the setup-node-for-integrated-frontend branch March 20, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants