Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache cargo subcommand install #119

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

sksat
Copy link
Member

@sksat sksat commented Mar 19, 2024

概要

cargo install でインストールしている cargo subcommand がキャッシュされていないので修正します

変更の意図や背景

同上

発端となる Issue

N/A

@sksat sksat added the invalid This doesn't seem right label Mar 19, 2024
@sksat sksat self-assigned this Mar 19, 2024
@sksat sksat requested a review from KOBA789 as a code owner March 19, 2024 08:43
@sksat
Copy link
Member Author

sksat commented Mar 19, 2024

キャッシュされて欲しくない時(新しい cargo-about が必要な時など)には現状のまま素朴にキャッシュすると困る可能性がありますが,そのような問題に対してはそもそも version 固定を行うべきであるため,別途扱うものとしたい

@KOBA789
Copy link
Member

KOBA789 commented Mar 19, 2024

これは rebase すると CI 通るようになるやつかな

@sksat
Copy link
Member Author

sksat commented Mar 19, 2024

rebase します

@sksat sksat force-pushed the fix-cache-cargo-subcommand branch from 4208b76 to 6be0e61 Compare March 19, 2024 08:51
@KOBA789 KOBA789 merged commit 461603f into main Mar 19, 2024
5 checks passed
@KOBA789 KOBA789 deleted the fix-cache-cargo-subcommand branch March 19, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants