Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo package check job in release workflow #109

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented Mar 13, 2024

概要

現在 cargo build などは通るものの cargo pacakge が通らないという状況になっている(#108)ため,それを Release workflow 中で検知できるようにする

変更の意図や背景

同上.また, #79 の準備でもある.

発端となる Issue

@sksat sksat added the enhancement New feature or request label Mar 13, 2024
@sksat sksat added this to the v0.7.0 milestone Mar 13, 2024
@sksat sksat self-assigned this Mar 13, 2024
@sksat sksat requested a review from KOBA789 as a code owner March 13, 2024 04:29
@KOBA789
Copy link
Member

KOBA789 commented Mar 14, 2024

@sksat #109, #111, #112 のマージ順の希望とかありますか

@sksat
Copy link
Member Author

sksat commented Mar 15, 2024

@KOBA789 そこまで依存関係無いですが,強いて言えば #111 -> #109 -> #112 ですかね

@KOBA789
Copy link
Member

KOBA789 commented Mar 15, 2024

ではその順序でマージします

@KOBA789 KOBA789 merged commit 2b47da1 into main Mar 15, 2024
4 checks passed
@KOBA789 KOBA789 deleted the add-cargo-package-check-job branch March 15, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants