Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo build with --locked option on Actions #402

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sksat
Copy link
Member

@sksat sksat commented Jan 8, 2025

@sksat sksat self-assigned this Jan 8, 2025
@sksat sksat force-pushed the feature/cargo-build-locked branch from f09d88e to 76d10ee Compare January 8, 2025 09:00
@sksat
Copy link
Member Author

sksat commented Jan 8, 2025

というか、commit してないのに the lock file /home/runner/work/c2a-core/c2a-core/Cargo.lock needs to be updated but --locked was passed to prevent this になってるのはおかしいな

@sksat
Copy link
Member Author

sksat commented Jan 8, 2025

いやこれまったく存在してない時にも出るか

@sksat sksat force-pushed the feature/cargo-build-locked branch from 87eb569 to 6166a9f Compare January 8, 2025 10:07
@sksat sksat changed the base branch from main to feature/add-cargo-lockfile January 8, 2025 10:07
@sksat sksat requested a review from ymgyt January 8, 2025 10:10
@sksat sksat mentioned this pull request Jan 8, 2025
@sksat sksat changed the title cargo build with --locked option cargo build with --locked option on Actions Jan 8, 2025
Copy link
Member

@ymgyt ymgyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです

Base automatically changed from feature/add-cargo-lockfile to main January 8, 2025 10:12
@sksat sksat force-pushed the feature/cargo-build-locked branch from 6166a9f to cecc949 Compare January 8, 2025 10:13
@sksat sksat merged commit 205f8e2 into main Jan 8, 2025
36 checks passed
@sksat sksat deleted the feature/cargo-build-locked branch January 8, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants