-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEM DUMP を整備する #245
Merged
Merged
MEM DUMP を整備する #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
meltingrabbit
added
enhancement
New feature or request
priority::high
priorityg high
labels
Dec 15, 2023
meltingrabbit
force-pushed
the
feature/memdump
branch
from
December 17, 2023 16:40
324833a
to
851e9da
Compare
meltingrabbit
force-pushed
the
feature/memdump
branch
from
December 17, 2023 16:48
9532975
to
b6d2cd0
Compare
@ToshiAki64 レビューお願いできますか? |
ToshiAki64
reviewed
Dec 17, 2023
ToshiAki64
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いいと思います。
TLM_ID に関して伺っている箇所の回答だけお願いできますか。
@meltingrabbit |
meltingrabbit
force-pushed
the
feature/memdump
branch
from
December 18, 2023 04:41
fd18733
to
dc40b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
CTCP 大改修 ut-issl/c2a-core#217 & WINGS が blob tlm に非対応だったことによって無効化されていた MEM DUMP をリファクタして使えうるように
Issue
詳細
header のコマンド説明を参照
検証結果
CI が通ればOK
補足
@kobkaz cc @ToshiAki64 @hender14
これで Gaia の blob tlm のテストができるはずです.
コマンドファイルは以下です
注1
0x569eda60
は, C2A 内部の最も大きいテーブルである BCT の先頭アドレスです(私の環境の場合.適当なアドレスいれてしまうと,そこを読もうとするので,セグフォで落ちると思います)こんな感じで VS Code でデバッグポイントうって見つけました.
ブレークポイント打つためのドキュメントは #247 です.
注2
begin と end の差を CTP よりも十分小さいサイズにすると,1 CTP で領域が完結するので,好きなサイズの blob CTP を作ることができます.