Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(eos_designs): Fix MPLS node types documentation in node_types table #4733

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Nov 15, 2024

Change Summary

cf title

Related Issue(s)

Fixes #4728

Component(s) name

arista.avd.eos_designs

Proposed changes

Update doc to match AVD behavior

How to test

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners November 15, 2024 15:03
@gmuloc gmuloc added this to the v5.1.0 milestone Nov 15, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4733
# Activate the virtual environment
source test-avd-pr-4733/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4728#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4728 --force
# Optional: Install AVD examples
cd test-avd-pr-4733
ansible-playbook arista.avd.install_examples

Copy link

sonarcloud bot commented Nov 15, 2024

@ClausHolbechArista ClausHolbechArista requested a review from a team November 15, 2024 15:39
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 15, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 18b6ac7 into aristanetworks:devel Nov 15, 2024
43 checks passed
@carlbuchmann carlbuchmann changed the title Doc: Fix MPLS node types documentation in node_types table Doc(eos_designs): Fix MPLS node types documentation in node_types table Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Doc(eos_designs) role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Fix MPLS routers in eos_designs documentation
3 participants