Feat(eos_cli_config_gen): Add route_map_in/out for router_bgp.address_family_evpn.neighbors[]
#4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4625
# Activate the virtual environment
source test-avd-pr-4625/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/route-map-af-evpn#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/route-map-af-evpn --force
# Optional: Install AVD examples
cd test-avd-pr-4625
ansible-playbook arista.avd.install_examples |
Shivani-gslab
requested changes
Oct 22, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
...e_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-evpn.yml
Outdated
Show resolved
Hide resolved
|
Shivani-gslab
approved these changes
Oct 23, 2024
MaheshGSLAB
approved these changes
Oct 24, 2024
…p.j2 Co-authored-by: Shivani-gslab <[email protected]>
…p.j2 Co-authored-by: Shivani-gslab <[email protected]>
laxmikantchintakindi
force-pushed
the
feat/route-map-af-evpn
branch
from
c49ecac
to
25c932d
Compare
ClausHolbechArista
previously requested changes
Oct 25, 2024
ClausHolbechArista
dismissed
their stale review
5.0 is out so this can be reviewed and merged
ClausHolbechArista
added
the
one approval
gmuloc
requested changes
Oct 28, 2024
|
gmuloc
approved these changes
Oct 29, 2024
|
Thank you very much for implementing it. 👍 |
gmuloc
pushed a commit
to gmuloc/avd
that referenced
this pull request
Oct 29, 2024
…ess_family_evpn.neighbors[]` (aristanetworks#4625)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add
route_map_in/outforrouter_bgp.address_family_evpn.neighbors[]Related Issue(s)
Fixes #4458
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Add support for route-map in or out per bgp neighbor under router_bgp.address_family_evpn:
How to test
Checklist
User Checklist
Repository Checklist