Refactor(eos_designs): Changed the redistribute_routes data model #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4544
# Activate the virtual environment
source test-avd-pr-4544/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@redistribute_eos_designs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,redistribute_eos_designs --force
# Optional: Install AVD examples
cd test-avd-pr-4544
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
MaheshGSLAB
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
laxmikantchintakindi
approved these changes
Oct 11, 2024
|
ClausHolbechArista
approved these changes
Oct 11, 2024
ClausHolbechArista
merged commit 2345a90
into
aristanetworks:devel
39 of 40 checks passed
nathanmusser
pushed a commit
to nathanmusser/avd
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Changed the redistribute_routes data model. Eerier it was list of redistribute protocols and now its dict or redistribute protocols
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Changed the redistribute_routes data model to new one(redistribute).
How to test
Run molecule and see the changes in structure config.
Checklist
User Checklist
Repository Checklist