Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Remove meta/runtime.yml from sanity ignore files #4442

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Sep 9, 2024

Change Summary

Remove meta/runtime.yml from sanity ignore files

Related Issue(s)

Fixes #

Component(s) name

arista.avd.<role-name>

Proposed changes

Remove meta/runtime.yml from sanity ignore files

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Sep 9, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4442
# Activate the virtual environment
source test-avd-pr-4442/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@remove_meta/runtime.yml#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,remove_meta/runtime.yml --force
# Optional: Install AVD examples
cd test-avd-pr-4442
ansible-playbook arista.avd.install_examples

Copy link

sonarcloud bot commented Sep 9, 2024

@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Sep 9, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review October 18, 2024 05:34
@Shivani-gslab Shivani-gslab requested review from a team as code owners October 18, 2024 05:34
Copy link

sonarcloud bot commented Oct 21, 2024

@carlbuchmann
Copy link
Member

Covered in PR #4638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants