Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Adding integration tests for cv_device_v3 #621

Merged
merged 19 commits into from
Aug 15, 2023
Merged

Test: Adding integration tests for cv_device_v3 #621

merged 19 commits into from
Aug 15, 2023

Conversation

Vibhu-gslab
Copy link
Collaborator

@Vibhu-gslab Vibhu-gslab commented May 29, 2023 •
edited by Shivani-chourasiya
Loading

Change Summary

Adding integration tests for cv_device_v3

Related Issue(s)

Fixes #

Component(s) name

arista.cvp.cv_device_v3

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly. (check the box if not applicable)
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab marked this pull request as draft May 29, 2023 11:53
@github-actions github-actions bot added module: cv_device_v3 Issue related to cv_device module in v3 module_utils: cv_client cv_client implementation issue labels May 29, 2023
sugetha24
sugetha24 reviewed May 31, 2023
View reviewed changes
ansible_collections/arista/cvp/examples/inventory.yml Outdated
@@ -0,0 +1,17 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this file from this PR? It will be added by another PR, that will be merged in before this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

sugetha24
sugetha24 reviewed May 31, 2023
View reviewed changes
ansible_collections/arista/cvp/molecule/cv_device_v3/test_cv_device_v3.yaml Outdated Show resolved Hide resolved
ansible_collections/arista/cvp/molecule/cv_device_v3/test_cv_device_v3.yaml Outdated
vars:
CVP_DEVICES_MOVE_DEVICE:
- fqdn: leaf1
parentContainerName: "Spine"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should move this to Leaf container just to make things logical

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

ansible_collections/arista/cvp/molecule/cv_device_v3/test_cv_device_v3.yaml Outdated

CVP_DEVICES_PARENT_CONTAINER_SAME:
- fqdn: leaf1
parentContainerName: "Spine"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Leaf

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

ansible_collections/arista/cvp/molecule/cv_device_v3/test_cv_device_v3.yaml Outdated
that:
- "MOVE_DEVICE_RUN.devices_moved.changed == true"
- "MOVE_DEVICE_RUN.devices_moved.devices_moved_count == 1"
- "MOVE_DEVICE_RUN.devices_moved.devices_moved_list == ['leaf1_to_Spine']"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaf1_to_Leaf

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

ansible_collections/arista/cvp/molecule/cv_device_v3/test_cv_device_v3.yaml Outdated
arista.cvp.cv_device_v3:
devices: '{{CVP_DEVICES_STATE_ABSENT}}'
state: absent
# ignore_errors: yes # ignoring errors so assertions can be done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actions github-actions bot requested a review from sugetha24 June 2, 2023 09:03
@Shivani-chourasiya Shivani-chourasiya force-pushed the cv_device_v3 branch 4 times, most recently from ce7391c to efaf30a Compare June 19, 2023 12:37
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review June 19, 2023 13:07
@sugetha24 sugetha24 mentioned this pull request Jun 26, 2023
Closed
9 tasks
sugetha24
sugetha24 reviewed Jul 27, 2023
View reviewed changes
ansible_collections/arista/cvp/molecule/cv_device_v3/test_cv_device_v3.yaml Outdated
- serialNumber: JPE504a004ea054
parentContainerName: L2_Leaf
configlets:
- 'AVD_Ipmi3'
Copy link
Contributor

@sugetha24 sugetha24 Jul 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a custom configlet and not what we assume to already be present on ATD?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

sugetha24
sugetha24 reviewed Jul 27, 2023
View reviewed changes
ansible_collections/arista/cvp/molecule/cv_device_v3/test_cv_device_v3.yaml Outdated
- serialNumber: JPE504a004ea054
parentContainerName: L2_Leaf
configlets:
- 'AVD_Ipmi3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sugetha24
Copy link
Contributor

Please upload images, configlets etc and then use it in the test rather than using something that is assumed to be present on ATD.

@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft July 28, 2023 11:45
@github-actions github-actions bot requested a review from sugetha24 July 28, 2023 13:06
@Shivani-chourasiya Shivani-chourasiya force-pushed the cv_device_v3 branch 2 times, most recently from 90d107f to a0a2540 Compare July 31, 2023 11:28
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review July 31, 2023 11:29
@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft July 31, 2023 14:18
@Shivani-gslab
Updating tests
3bbb648 
Some minor fix

Updated tests
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review August 2, 2023 18:47
@github-actions github-actions bot requested a review from sugetha24 August 3, 2023 11:07
sugetha24
sugetha24 reviewed Aug 3, 2023
View reviewed changes
ansible_collections/arista/cvp/molecule/cv_device_v3/test_apply_detach_bundle.yml
action: add
bundle_name: "{{BUNDLE_NAME}}"
image_list:
- "{{IMAGE_NAME}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a Terminattr to be added to the bundle. Please add a terminattr to this bundle

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions github-actions bot requested a review from sugetha24 August 4, 2023 06:14
@Shivani-chourasiya Shivani-chourasiya force-pushed the cv_device_v3 branch 2 times, most recently from e690b07 to 1019dcc Compare August 4, 2023 06:49
sugetha24
sugetha24 reviewed Aug 9, 2023
View reviewed changes
ansible_collections/arista/cvp/molecule/cv_device_v3/test_apply_detach_bundle.yml Outdated
regexp_filter: "{{DEVICE_NAME}}"
register: CV_FACTS_V3_RESULT

- name: "Push config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we testing push configlet here rather than in test_apply_detach_configlets.yaml ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not testing it here, just uploading it to be used while attaching/detaching bundle

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it without configlets, removing configlet part.
Thanks!

...ions/arista/cvp/molecule/cv_device_v3/test_decommission_factory_reset_provisioning_reset.yml Outdated Show resolved Hide resolved
noredistribution
noredistribution approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested successfully on dual DC ATD, lgtm!+1

@sugetha24 sugetha24 merged commit a24b03c into aristanetworks:devel Aug 15, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shivani-chourasiya Shivani-chourasiya Shivani-chourasiya left review comments

@noredistribution noredistribution noredistribution approved these changes

@sugetha24 sugetha24 sugetha24 approved these changes

@guillaumeVilar guillaumeVilar Awaiting requested review from guillaumeVilar

Assignees

@Vibhu-gslab Vibhu-gslab

Labels
module: cv_device_v3 Issue related to cv_device module in v3 module_utils: cv_client cv_client implementation issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vibhu-gslab @sugetha24 @noredistribution @Shivani-chourasiya @Shivani-gslab