Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Action #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Step Action #18

wants to merge 2 commits into from

Conversation

genepaul
Copy link
Collaborator

@genepaul genepaul commented Feb 2, 2016

First of all, thanks for providing this project, it has been of great use to me!

I found some use for having an action that just runs as soon as you navigate to a step, so I thought I'd contribute it back. If you don't think it's good to have in the base component, I'm good with that, but just wanted to provide the option.

This could be used to fetch data when a step is loaded. I suppose the user could listen for wizard:Next or slideBox.slideChanged, but this integrates it into the component more declaratively.

@timemachine3030
Copy link

This is a great patch, I too need an 'on display' function call.

@genepaul
Copy link
Collaborator Author

genepaul commented Jan 9, 2017

@timemachine3030 - it appears this repo is not actively maintained. Feel free to fork my fork. Mine may be out of date currently, but if you're interested in using it, I can make the effort to get it back in line with master.

@arielfaur
Copy link
Owner

Hi @genepaul ! Sorry for the delay. You are right, i am not maintaining this repo (I have moved on to Ionic 2). If you want, I can add you to this repo if you want to do the merge.

@genepaul
Copy link
Collaborator Author

I'd be happy to maintain this, as I am using it in a project of my own that isn't looking to upgrade to Ionic 2 yet. Curious - will you be creating something like this for Ionic 2 as well? I haven't looked at it too extensively.

@arielfaur
Copy link
Owner

@genepaul I've just added you to the repo as collaborator 😄

@arielfaur
Copy link
Owner

I am not so sure whether it makes sense to create a module like this one for Ionic 2 since it seems easier to implement a wizard from scratch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants