fix(operator): allow retries to consider exit code from init container and don't consider node as pending if init failed. Fixes #11354/#10717/#10045

[tooptoop4]

Fixes #11354 and #10717 and #10045

Before this fix it would always go into pending because main container was waiting state (

argo-workflows/workflow/controller/operator.go

Line 1404 in 4742e9d

woc.markNodePhase(ctrNodeName, wfv1.NodePending)

) even though init container already terminated with non-0 exit

This supersedes #13852

cc @terrytangyuan

[jswxstw]

Before this fix it would always go into pending because main container was waiting state even though init container already terminated with non-0 exit

This will only be encountered when using ContainerSet, right?

[tooptoop4]

Before this fix it would always go into pending because main container was waiting state even though init container already terminated with non-0 exit

This will only be encountered when using ContainerSet, right?

no, see the logs/comments in the linked issues