fix(side-navbar): keyboard a11y #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace div with button to allow activation using space and enter Signed-off-by: Gaurav Gupta<[email protected]>
gaurav5430
force-pushed
the
sidenav-accessibility
branch
from
14f8b22
to
6c1c260
Compare
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
problem/stale
|
Looks like DCO is missing a space (between name and the |
Thanks for reopening this, I might find time to fix the DCO issue and rebase this |
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
problem/stale
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
problem/stale
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
problem/stale
|
I think that this would also make the buttons clickable with vimium! |
agilgur5
reviewed
May 12, 2024
| @@ -35,10 +35,10 @@ export const NavBar: React.FunctionComponent<NavBarProps> = (props: NavBarProps, | |||
| <div className='nav-bar__version'>{props.version && props.version()}</div> | |||
| {(props.items || []).map((item) => ( | |||
| <Tooltip content={item.title} placement='right' arrow={true} key={item.path + item.title}> | |||
| <div className={classNames('nav-bar__item', { active: isActiveRoute(locationPath, item.path) })} | |||
| <button type="button" className={classNames('nav-bar__item', { active: isActiveRoute(locationPath, item.path) })} | |||
There was a problem hiding this comment.
I think this can actually just use a <Link> element from react-router, which would also solve #166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace div with button to allow activation using space and enter.
This fixes one of the issues mentioned in #221