Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-workflows): Upgrade Argo Workflows to v3.6.0 #3037

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yu-croco
Copy link
Collaborator

@yu-croco yu-croco commented Nov 15, 2024

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@yu-croco
Copy link
Collaborator Author

😮‍💨

Error: INSTALLATION FAILED: create: failed to create: Secret "sh.helm.release.v1.argo-workflows-9knmn2ard5.v1" is invalid: data: Too long: must have at most 1048576 bytes

https://github.com/argoproj/argo-helm/actions/runs/11847799319/job/33018184325?pr=3037

@mkilchhofer
Copy link
Member

😮‍💨

Error: INSTALLATION FAILED: create: failed to create: Secret "sh.helm.release.v1.argo-workflows-9knmn2ard5.v1" is invalid: data: Too long: must have at most 1048576 bytes

https://github.com/argoproj/argo-helm/actions/runs/11847799319/job/33018184325?pr=3037

Sh*t. Are we really there now? The chart is too big for the 1M Secret limit 😢

@tico24
Copy link
Member

tico24 commented Nov 15, 2024

So... running ct install --config ../../.github/configs/ct-install.yaml --charts . locally and it works fine. So this might be a GHA thing, or we've just got unlucky twice?

@vladlosev
Copy link
Collaborator

Sh*t. Are we really there now? The chart is too big for the 1M Secret limit 😢

Now I understand why Helm decided to deal with CRDs the way it did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants