Add nalgebra 0.33 support

[0e4ef622]

Since the Allocator trait changed, I added a trait alias to mimic the old Allocator trait.

[stefan-k]

Hi, thanks also for this PR! Would you mind rebasing now that #504 is merged?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (a9e3eb7) to head (168d918).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
- Coverage   92.08%   91.49%   -0.60%     
==========================================
  Files         178      178              
  Lines       24455    23623     -832     
==========================================
- Hits        22520    21613     -907     
- Misses       1935     2010      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stefan-k]

Thanks a lot for this work, this is highly valuable! :) I have one question out of curiosity, otherwise this is good to go!

[stefan-k]

I'm not an nalgebra expert, could you explain to me why simba is needed as a dependency?

[0e4ef622]

simba is already a dependency of nalgebra, it's just that nalgebra 0.33 no longer re-exports certain traits used in this crate like simba::scalar::ClosedAdd.

[0e4ef622]

Actually taking a second look, I'm just replacing ClosedAdd with ClosedAddAssign which is reexported in 0.33, so I could remove simba and use the trait from nalgebra instead.

[stefan-k]

If its not necessary I'd prefer it if it were removed, simply to avoid having to manage it.

[0e4ef622]

Ok, I've removed it.

[stefan-k]

Could you add testing the 0.33 version to the CI, please?
This would be the appropriate place:

argmin/.github/workflows/ci.yml

Lines 120 to 130 in be2444e

	# nalgebra
	- name: argmin-math (nalgebra_latest)
	run: cargo test -p argmin-math --no-default-features --features "nalgebra_latest"
	- name: argmin-math (nalgebra_v0_32)
	run: cargo test -p argmin-math --no-default-features --features "nalgebra_v0_32"
	- name: argmin-math (nalgebra_v0_31)
	run: cargo test -p argmin-math --no-default-features --features "nalgebra_v0_31"
	- name: argmin-math (nalgebra_v0_30)
	run: cargo test -p argmin-math --no-default-features --features "nalgebra_v0_30"
	- name: argmin-math (nalgebra_v0_29)
	run: cargo test -p argmin-math --no-default-features --features "nalgebra_v0_29"

[AdrianEddy]

any update?

[david-cattermole]

Hi @stefan-k, it appears that @0e4ef622 added CI support in 0e4ef622@168d918.

[stefan-k]

Apologies for being so absent recently. I'll try to address some of the open pull requests on Sunday.

[david-cattermole]

Apologies for being so absent recently. I'll try to address some of the open pull requests on Sunday.

No problem at all, we all get busy! 😄 Thank you for everything you do!
argmin is fantastic, and a lot of people really admire and appreciate your hard-work (I know I do).

[stefan-k]

No problem at all, we all get busy! 😄 Thank you for everything you do! argmin is fantastic, and a lot of people really admire and appreciate your hard-work (I know I do).

Thanks for the kind words! :)
LGTM, Huge thanks to @0e4ef622 for your work and for addressing my request! :)