Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observer based on tracing crate #475

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

stefan-k
Copy link
Member

  • Observer based on tracing crate
  • Tracing observer example
  • Remove Debug impl of KV
  • Added Into<f64> trait bound on Float trait

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 91.43%. Comparing base (ce905b9) to head (0d82eed).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/argmin-observer-tracing/src/lib.rs 0.00% 19 Missing ⚠️
crates/argmin/src/core/kv.rs 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   91.52%   91.43%   -0.09%     
==========================================
  Files         163      164       +1     
  Lines       21734    21755      +21     
==========================================
  Hits        19891    19891              
- Misses       1843     1864      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants