Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check password account for recovery phrase from main page #1978

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

STP5940
Copy link

@STP5940 STP5940 commented Mar 30, 2023

Issue / feature description

Save the recovery phrase from main page not check password for account

Changes

edit routes from "setupSeedRecovery(returnTo)" to "settingsSeed(returnTo)"

ie:

  • Goto main page path: /account/tokens
  • (Click) Set up account recovery (/recovery?returnTo=/account/tokens)
  • (Click) Save the recovery phrase

Set up account recovery > Save the recovery phrase
Recovery phrase not check password
@STP5940 STP5940 changed the title check password account for recovery phrase check password account for recovery phrase from main page Mar 30, 2023
@dhruvkelawala
Copy link
Contributor

Thanks for your contribution! I'll have a look today. Can you explain more on why this was needed?

@STP5940
Copy link
Author

STP5940 commented Mar 31, 2023

Thanks for your contribution! I'll have a look today. Can you explain more on why this was needed?

If you want a recovery phrase, go to settings and select Show recovery phrase menu. The program will ask for the account password.

But if recovering phrase by going to the homepage and selecting menu Set up account recovery > Save the recovery phrase
The program will not ask for a password.

If the user leaves the screen open This puts users at risk of having their phrase stolen.

extension Version: v5.3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants