-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use systemd timer in lieu of cron + New Checkbox Support + Typo + New Script Support #51
Conversation
Don't we need a daemon reload everytime the file is changed ? |
@ipitio we might need a way to replace the current crontab with a systemd timer for existing users. |
All they would have to do is open Speedtest settings and click save* (so it would be updated when they next update settings, giving us time to iron out any bugs), or that could be automated. *I changed save to confirm as I felt it's more appropriate due to the flush and new chart default and update/uninstall operations. |
Todo: use screen, copy modded admin and pihole, check if update/uninstall failed, and if so, move them back and notify user that command(s) failed and to try again or attempt manually |
@ipitio how about we add code to remove existing crontab if they save settings and remove it after a few future releases? |
That's exactly what it does at the moment! SetService() is (and SetCrontab() was) only called when saving settings. |
Done |
This is part of arevindh/AdminLTE#70
Features:
mod.sh
Fixes: