Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use systemd timer in lieu of cron + New Checkbox Support + Typo + New Script Support #51

Merged
merged 78 commits into from
Feb 11, 2023

Conversation

ipitio
Copy link
Collaborator

@ipitio ipitio commented Jan 15, 2023

This is part of arevindh/AdminLTE#70

Features:

Fixes:

  • Typo
    • Chage -> Change

@ipitio ipitio changed the title Typo + New Checkbox Support Use systemd timer in lieu of cron + New Checkbox Support + Type Jan 19, 2023
@ipitio ipitio changed the title Use systemd timer in lieu of cron + New Checkbox Support + Type Use systemd timer in lieu of cron + New Checkbox Support + Typo Jan 19, 2023
@arevindh
Copy link
Owner

Don't we need a daemon reload everytime the file is changed ?

@arevindh
Copy link
Owner

@ipitio we might need a way to replace the current crontab with a systemd timer for existing users.

@ipitio
Copy link
Collaborator Author

ipitio commented Jan 20, 2023

All they would have to do is open Speedtest settings and click save* (so it would be updated when they next update settings, giving us time to iron out any bugs), or that could be automated.

*I changed save to confirm as I felt it's more appropriate due to the flush and new chart default and update/uninstall operations.

@ipitio ipitio changed the title Use systemd timer in lieu of cron + New Checkbox Support + Typo Use systemd timer in lieu of cron + New Checkbox Support + Typo + Native Update and Uninstall Support Jan 20, 2023
@ipitio
Copy link
Collaborator Author

ipitio commented Jan 20, 2023

Todo: use screen, copy modded admin and pihole, check if update/uninstall failed, and if so, move them back and notify user that command(s) failed and to try again or attempt manually

@arevindh
Copy link
Owner

@ipitio how about we add code to remove existing crontab if they save settings and remove it after a few future releases?

@ipitio
Copy link
Collaborator Author

ipitio commented Jan 20, 2023

@ipitio how about we add code to remove existing crontab if they save settings and remove it after a few future releases?

That's exactly what it does at the moment! SetService() is (and SetCrontab() was) only called when saving settings.

@ipitio
Copy link
Collaborator Author

ipitio commented Jan 21, 2023

Todo: use screen, copy modded admin and pihole, check if update/uninstall failed, and if so, move them back and notify user that command(s) failed and to try again or attempt manually

Done

@ipitio ipitio changed the title Use systemd timer in lieu of cron + New Checkbox Support + Typo + Native Update and Uninstall Support Use systemd timer in lieu of cron + New Checkbox Support + Typo + New Script Support Jan 29, 2023
@arevindh arevindh merged commit 158b542 into arevindh:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants