Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented package_index.json signature verification #791

Merged
merged 8 commits into from
Jul 7, 2020
Merged

Implemented package_index.json signature verification #791

merged 8 commits into from
Jul 7, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 6, 2020

  • a .sig file is downloaded together with package file on downloads.arduino.cc domain
  • the signature is verified against the Arduino public GPG keys
  • if the signature is valid both files, index and signature, are copied over older ones in data directory

@cmaglie cmaglie requested review from ubidefeo and rsora July 6, 2020 17:18
@cmaglie cmaglie self-assigned this Jul 7, 2020
@cmaglie cmaglie added this to the 0.12.0 milestone Jul 7, 2020
rsora
rsora approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔏

@rsora
Copy link
Contributor

rsora commented Jul 7, 2020 •
edited
Loading

(BTW let's keep a close look on GeertJohan/go.rice#159 😉 )

@cmaglie cmaglie merged commit 1ad33cd into arduino:master Jul 7, 2020
@cmaglie cmaglie deleted the signature-check branch July 7, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @rsora