Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-2614 - Correctly bundle SVGs, fix external dependencies #42

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Nov 10, 2023

Description

  • Introduce @svgr/rollup to correctly bundle svgs
  • Remove postcss step and dependency
  • Bundle tslib utilities into library
  • Do not include tailwindcss configuration utilities into bundle

Task: APP-2614

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team November 10, 2023 14:17
@cgero-eth cgero-eth marked this pull request as ready for review November 10, 2023 14:17
@Fabricevladimir Fabricevladimir merged commit 7bd0a0b into main Nov 14, 2023
4 checks passed
@Fabricevladimir Fabricevladimir deleted the fix-build branch November 14, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants