Skip to content

Commit

Permalink
feat(APP-3615): Update DialogHeader component to not truncate descrip…
Browse files Browse the repository at this point in the history
…tion strings (#383)
  • Loading branch information
cgero-eth authored Jan 8, 2025
1 parent 525b6e9 commit 61bff70
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Changed

- Update style of `ProposalActionItem` module component, render link to block explorer for target address
- Update `<DialogHeader />` core component to not truncate description strings
- Update style of `<ProposalActionItem />` module component, render link to block explorer for target address
- Rename `tokenPrice` property to `amountUsd` on `<TransactionDataListItem />` module component
- Update workflow to deploy Storybook application to Github pages
- Update minor and patch NPM dependencies
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const DialogHeader: React.FC<IDialogHeaderProps> = (props) => {

return (
<div
className="flex w-full items-center gap-x-3 rounded-t-xl bg-modal-header px-4 pb-2 pt-4 backdrop-blur-md md:gap-x-4 md:px-6 md:pt-6"
className="flex w-full items-start gap-x-3 rounded-t-xl bg-modal-header px-4 pb-2 pt-4 backdrop-blur-md md:gap-x-4 md:px-6 md:pt-6"
{...otherProps}
>
{showBackButton && (
Expand All @@ -50,12 +50,10 @@ export const DialogHeader: React.FC<IDialogHeaderProps> = (props) => {
onClick={onBackClick}
/>
)}
<div className="min-w-0 flex-1 space-y-0.5">
<div className="min-w-0 flex-1 gap-0.5">
<Title className="flex-1 truncate text-lg leading-tight text-neutral-800">{title}</Title>
{description && (
<Description className="flex-1 truncate text-sm leading-normal text-neutral-500">
{description}
</Description>
<Description className="flex-1 text-sm leading-normal text-neutral-500">{description}</Description>
)}
</div>
<Close asChild={true}>
Expand Down

0 comments on commit 61bff70

Please sign in to comment.