Feature/keyboard and mouse actions #12
Conversation
Aquality.WinAppDriver/src/Aquality.WinAppDriver/Actions/KeyboardActions.cs
Outdated
Show resolved
Hide resolved
Aquality.WinAppDriver/src/Aquality.WinAppDriver/Actions/KeyboardActions.cs
Outdated
Show resolved
Hide resolved
Aquality.WinAppDriver/src/Aquality.WinAppDriver/Applications/ApplicationManager.cs
Show resolved
Hide resolved
Aquality.WinAppDriver/src/Aquality.WinAppDriver/Elements/Actions/KeyboardActions.cs
Outdated
Show resolved
Hide resolved
| /// <see cref="OpenQA.Selenium.Keys.Command"/>, | ||
| /// <see cref="OpenQA.Selenium.Keys.LeftAlt"/>, | ||
| /// <see cref="OpenQA.Selenium.Keys.LeftShift"/>, | ||
| /// <see cref="OpenQA.Selenium.Keys.Shift"/> |
There was a problem hiding this comment.
Do you really need this list of Keys in summary?
There was a problem hiding this comment.
yes I do. Selenium has it. We either need to follow it's notation, or define a custom Enum with mapping to this values, and accept only them in our methods. I like the first variant more, but we can discuss it
| @@ -28,7 +32,7 @@ public override Application Application | |||
| var serviceUrl = driverService.ServiceUrl; | |||
| localizationLogger.Info("loc.application.driver.service.local.start", serviceUrl); | |||
| var driver = GetDriver(serviceUrl, driverSettings.AppiumOptions, timeoutConfiguration.Command); | |||
| return new Application(driver, timeoutConfiguration, localizationLogger); | |||
| return new Application(driver, timeoutConfiguration, localizationLogger, keyboardActions); | |||
There was a problem hiding this comment.
It looks very strange. Why do you need to pass actions to the Application?
There was a problem hiding this comment.
in order to use the same instance of the keyboardActions, I guess
| /// </summary> | ||
| /// <param name="key">Keyboard key to define.</param> | ||
| /// <returns>Readable value.</returns> | ||
| public static string GetLoggableValueForKeyboardKey(this string key) |
There was a problem hiding this comment.
Why it is public? It looks like helper for some library actions, but not as public method that should be available in client code.
There was a problem hiding this comment.
don't see any reason why should we hide the functionality that could be used by the customer.
I can imagine situations when I want to log this value but I cannot.
Seems that I should rework this keys to public enum...
Add xml documentation to library. Fix documentation for some classes. Add Scroll as mouse action to resolve #14
Aquality.WinAppDriver/src/Aquality.WinAppDriver/Elements/Actions/IMouseActions.cs
Show resolved
Hide resolved
Aquality.WinAppDriver/src/Aquality.WinAppDriver/Elements/Actions/IMouseActions.cs
Show resolved
Hide resolved
Aquality.WinAppDriver/src/Aquality.WinAppDriver/Elements/Actions/KeyboardActions.cs
Show resolved
Hide resolved
Aquality.WinAppDriver/src/Aquality.WinAppDriver/Resources/Localization/be.json
Show resolved
Hide resolved
Aquality.WinAppDriver/tests/Aquality.WinAppDriver.Tests/Elements/Actions/MouseActionsTests.cs
Show resolved
Hide resolved
Aquality.WinAppDriver/tests/Aquality.WinAppDriver.Tests/Localization/LocalizationFilesTest.cs
Show resolved
Hide resolved
Add KeyboardActions for Application to close #9
Implement KeyboardActions for element.
implemented MouseActions for custom element and for the whole application to resolve #8
Add localization for new actions.
Add xml documentation to library. Fix documentation for some classes.
Add Scroll as mouse action to resolve #14