Feature/auto release (#138)

* #18 Fix pipeline to create releases on GitHub * #127 Fix code smells
aquality-automation · Aug 29, 2019 · f7814ad · f7814ad
1 parent fc190e9
commit f7814ad
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/Aquality.Selenium/src/Aquality.Selenium/Configurations/RetryConfiguration.cs b/Aquality.Selenium/src/Aquality.Selenium/Configurations/RetryConfiguration.cs
@@ -24,7 +24,7 @@ public RetryConfiguration(JsonFile settingsFile)
 
         private int GetIntFromSettings(string name)
         {
-            return settingsFile.GetValue<int>($".retry.{name}");;
+            return settingsFile.GetValue<int>($".retry.{name}");
         }
 
         public int Number { get; }

diff --git a/Aquality.Selenium/src/Aquality.Selenium/Configurations/WebDriverSettings/DriverSettings.cs b/Aquality.Selenium/src/Aquality.Selenium/Configurations/WebDriverSettings/DriverSettings.cs
@@ -61,22 +61,22 @@ public virtual string DownloadDir
 
         protected void SetCapabilities(DriverOptions options, Action<string, object> addCapabilityMethod = null)
         {
-            foreach(var capability in BrowserCapabilities)
+            foreach (var capability in BrowserCapabilities)
             {
                 try
                 {
                     var defaultAddCapabilityMethod = addCapabilityMethod ?? options.AddAdditionalCapability;
                     defaultAddCapabilityMethod(capability.Key, capability.Value);
                 } 
-                catch(ArgumentException exception)
+                catch (ArgumentException exception)
                 {
                     if(exception.Message.StartsWith("There is already an option"))
                     {
                         SetKnownProperty(options, capability, exception);
                     }
                     else
                     {
-                        throw exception;
+                        throw;
                     }
                 }
             }

diff --git a/Aquality.Selenium/src/Aquality.Selenium/Elements/ElementSupplier.cs b/Aquality.Selenium/src/Aquality.Selenium/Elements/ElementSupplier.cs
@@ -11,5 +11,5 @@ namespace Aquality.Selenium.Elements
     /// <param name="name">Element name</param>
     /// <param name="state">Element state</param>
     /// <returns>Element instance of type T</returns>
-    public delegate T ElementSupplier<T>(By locator, string name, ElementState state) where T : IElement;
+    public delegate T ElementSupplier<out T>(By locator, string name, ElementState state) where T : IElement;
 }
diff --git a/Aquality.Selenium/src/Aquality.Selenium/Utilities/ElementActionRetrier.cs b/Aquality.Selenium/src/Aquality.Selenium/Utilities/ElementActionRetrier.cs
@@ -8,7 +8,7 @@ namespace Aquality.Selenium.Utilities
     /// <summary>
     /// Retries an action or function when <see cref="StaleElementReferenceException"/> or <see cref="InvalidElementStateException"/> occures.
     /// </summary>
-    internal sealed class ElementActionRetrier
+    internal static class ElementActionRetrier
     {
         /// <summary>
         /// Retries the action when <see cref="StaleElementReferenceException"/> or <see cref="InvalidElementStateException"/> occures.

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -64,7 +64,6 @@ steps:
     repositoryName: 'aquality-automation/aquality-selenium-dotnet'
     action: 'create'
     tag: 'v$(GitVersion.NuGetVersion)'
-    title: 'v$(GitVersion.NuGetVersion)'
-    tagSource: 'auto'
+    tagSource: 'manual'
     isPreRelease: contains(variables['GitVersion.NuGetVersion'], '-')
   condition: and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/master'))