Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Appium 9.2.3 and Selenium 4.22.0 #43

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

mialeska
Copy link
Contributor

Update device and driver settings to use BaseOptions instead of Capabilities
(in accordance with changes introduced in latest version, see appium/java-client#2184)

Update device and driver settings to use BaseOptions instead of Capabilities
(in accordance with changes introduced in latest version, see appium/java-client#2184)
@mialeska mialeska added the enhancement New feature or request label Jul 16, 2024
@mialeska mialeska self-assigned this Jul 16, 2024
Copy link

coderabbitai bot commented Jul 16, 2024

Walkthrough

This update primarily focuses on upgrading dependency versions in the pom.xml file and refactoring the code to use BaseOptions from io.appium.java_client.remote.options instead of Capabilities and DesiredCapabilities from org.openqa.selenium. This change affects multiple files within the aquality.appium.mobile.configuration package, ensuring consistency and compatibility with the latest versions of the dependencies.

Changes

File Path Change Summary
pom.xml Updated versions for aquality-selenium-core, java-client, testng, and commons-io.
src/main/java/.../DeviceSettings.java Replaced Capabilities and DesiredCapabilities with BaseOptions<?>.
src/main/java/.../DriverSettings.java Updated methods to return BaseOptions<?> instead of Capabilities.
src/main/java/.../IDeviceSettings.java, IDriverSettings.java Changed method signatures and imports to use BaseOptions<?> instead of Capabilities.

Poem

In the world of code, updates do flow,
Dependencies rise, and old ones must go.
From Capabilities to BaseOptions we shift,
Ensuring our drivers keep up with the drift.
A small change today, but progress we sow.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3d6cc65 and f963668.

Files selected for processing (5)
  • pom.xml (2 hunks)
  • src/main/java/aquality/appium/mobile/configuration/DeviceSettings.java (2 hunks)
  • src/main/java/aquality/appium/mobile/configuration/DriverSettings.java (3 hunks)
  • src/main/java/aquality/appium/mobile/configuration/IDeviceSettings.java (2 hunks)
  • src/main/java/aquality/appium/mobile/configuration/IDriverSettings.java (2 hunks)
Additional comments not posted (12)
src/main/java/aquality/appium/mobile/configuration/IDeviceSettings.java (2)

3-3: Approved import change from Capabilities to BaseOptions.

This change is consistent with the PR's goal to update to the latest versions of Appium and Selenium, which use BaseOptions instead of Capabilities.


12-14: Approved method signature change to return BaseOptions<?>.

The update to return BaseOptions<?> instead of Capabilities aligns with the new standards introduced by the updated versions of Appium and Selenium.

src/main/java/aquality/appium/mobile/configuration/IDriverSettings.java (2)

3-3: Approved import change from Capabilities to BaseOptions.

This change is consistent with the PR's goal to update to the latest versions of Appium and Selenium, which use BaseOptions instead of Capabilities.


12-14: Approved method signature change to return BaseOptions<?>.

The update to return BaseOptions<?> instead of Capabilities aligns with the new standards introduced by the updated versions of Appium and Selenium.

src/main/java/aquality/appium/mobile/configuration/DeviceSettings.java (2)

5-5: Approved import change from Capabilities to BaseOptions.

This change is consistent with the PR's goal to update to the latest versions of Appium and Selenium, which use BaseOptions instead of Capabilities.


29-31: Approved method implementation change to use BaseOptions<?>.

The implementation of getCapabilities using BaseOptions<?> is correct and aligns with the updated interface. Ensure that setCapability is correctly implemented in BaseOptions.

src/main/java/aquality/appium/mobile/configuration/DriverSettings.java (2)

7-7: Approved import change from Capabilities to BaseOptions.

This change is consistent with the PR's goal to update to the latest versions of Appium and Selenium, which use BaseOptions instead of Capabilities.


31-33: Approved method implementation changes to use BaseOptions<?>.

The implementations of getCapabilities and getDeviceCapabilities using BaseOptions<?> are correct and align with the updated interface. Ensure that setCapability and merge are correctly implemented in BaseOptions.

Also applies to: 70-70

pom.xml (4)

192-192: Approved version update for aquality-selenium-core.

The update from 4.0.2 to 4.0.3 is minor and likely non-breaking. However, ensure compatibility with other updated dependencies.


198-198: Approved version update for java-client.

The update to 9.2.3 aligns with the PR's objective of updating Appium. This is a patch version update, usually safe and focused on bug fixes.


204-204: Approved version update for testng.

The update from 7.9.0 to 7.10.2 is a minor version change. Review the release notes for testng to ensure compatibility and understand any new features or breaking changes.


218-218: Approved version update for commons-io.

The update from 2.15.1 to 2.16.1 is minor and typically involves bug fixes or performance improvements. Ensure it does not introduce issues with other libraries.

@mialeska mialeska merged commit 38bb5c2 into master Jul 17, 2024
5 checks passed
@mialeska mialeska deleted the support/update-to-appium-9.2.3 branch July 17, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant