Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to .NET 8 and NUnit 4 #20

Merged
merged 3 commits into from
May 13, 2024
Merged

Migrate to .NET 8 and NUnit 4 #20

merged 3 commits into from
May 13, 2024

Conversation

mialeska
Copy link
Contributor

Use new language features, such as primary constructor Update package references
Add application termination

@mialeska
Migrate to .NET 8 and NUnit 4.
c190fbe 
Use new language features, such as primary constructor
Update package references
Add application termination
@mialeska mialeska added the enhancement New feature or request label May 13, 2024
@mialeska mialeska self-assigned this May 13, 2024
@mialeska mialeska changed the title Migrate to .NET 8 and NUnit 4. Migrate to .NET 8 and NUnit 4 May 13, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 13, 2024 •
edited
Loading

Walkthrough

The project updates involve transitioning from .NET 6.0 to .NET 8.0, enhancing dependency management, and refining code structures for clarity and maintainability. These changes modernize the project and optimize testing framework integration.

Changes

File Path Change Summary
.github/workflows/.../test-with-allure-report.yml, azure-pipelines.yml Updated .NET version to 8.0.x, adjusted test platform, and reporting paths.
Aquality.Appium.Mobile.Template/.../*.csproj Target framework set to net8.0, upgraded package references.
Aquality.Appium.Mobile.Template/.../Hooks/*.cs Refactored for improved dependency injection and simplified constructors. Changes in method accessibility and parameters.
Aquality.Appium.Mobile.Template/.../StepDefinitions/*.cs Constructor and assertion modifications for better integration with updated dependencies.

Poem

🐰✨
Hoppity hop, the code does leap,
From old to new, the changes seep.
Dot NET grows like springtime flowers,
Bugs scurry away from refactor powers.
Cheers to clean code, we chase the dawn, 🌅
With every commit, a new era is born.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 13, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 38034db and c190fbe.
Files selected for processing (10)
  • .github/workflows/test-with-allure-report.yml (5 hunks)
  • Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Aquality.Appium.Mobile.Template.SpecFlow.csproj (1 hunks)
  • Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Hooks/ApplicationHooks.cs (1 hunks)
  • Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Hooks/ObjectContainerHooks.cs (1 hunks)
  • Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Hooks/PluginsHooks.cs (1 hunks)
  • Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Hooks/ScreenshotHooks.cs (1 hunks)
  • Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/StepDefinitions/CommonSteps.cs (1 hunks)
  • Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/StepDefinitions/LoginSteps.cs (2 hunks)
  • Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.csproj (2 hunks)
  • azure-pipelines.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.csproj
Additional comments not posted (14)
Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Hooks/ApplicationHooks.cs (1)

10-15: Change to static method CloseApplication looks good. Ensure all calls to this method are updated.

Verification successful

Change to static method CloseApplication is confirmed to have no impact on existing code as there are no calls to this method in the codebase.

  • No further action is required regarding the update of calls to this method.
Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all calls to `CloseApplication` are updated to static calls.

# Test: Search for the function usage. Expect: Only static calls.
rg --type cs $'ApplicationHooks.CloseApplication'

Length of output: 48

Script:

#!/bin/bash
# Description: Broaden the search to verify all calls to `CloseApplication` are updated to static calls.

# Test: Search for the function usage in all files, not just C# files, to ensure no references are missed.
rg 'ApplicationHooks.CloseApplication'

Length of output: 38

Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Hooks/ObjectContainerHooks.cs (1)

9-15: Constructor injection in ObjectContainerHooks enhances modularity and testability.

Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/StepDefinitions/CommonSteps.cs (1)

9-17: Use of constructor injection and fluent assertions in CommonSteps enhances clarity and maintainability.

Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Hooks/ScreenshotHooks.cs (2)

11-11: Simplification in ScreenshotHooks constructor improves decoupling.

11-11: Proper error handling in TakeScreenshot method ensures robustness.

Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/StepDefinitions/LoginSteps.cs (1)

Line range hint 10-25: Constructor injection and fluent assertions in LoginSteps enhance clarity and maintainability.

Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Aquality.Appium.Mobile.Template.SpecFlow.csproj (1)

4-16: Updates to target framework and package versions in Aquality.Appium.Mobile.Template.SpecFlow.csproj are well-aligned with .NET 8 migration.

Aquality.Appium.Mobile.Template/Aquality.Appium.Mobile.Template.SpecFlow/Hooks/PluginsHooks.cs (2)

12-12: Constructor injection in PluginsHooks enhances modularity and testability.

12-12: Clear scenario naming in PluginsHooks methods improves traceability of test results.

azure-pipelines.yml (1)

133-136: Updates to .NET version in azure-pipelines.yml are well-aligned with .NET 8 migration.

.github/workflows/test-with-allure-report.yml (4)

28-28: Updated ALLURE_RESULTS path to reflect the new .NET version. This change is consistent with the migration to .NET 8.

37-37: Updated macOS runner version to macos-12. This change likely improves compatibility or stability with the new .NET version.

46-46: Updated .NET version to 8.0.x in the setup-dotnet action for the Android job. This change supports the migration to .NET 8.

110-110: Updated .NET version to 8.0.x in the setup-dotnet action for the iOS job. This change supports the migration to .NET 8.

coderabbitai[bot]
coderabbitai bot reviewed May 13, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c190fbe and e9ef94b.
Files selected for processing (1)
  • .github/workflows/test-with-allure-report.yml (5 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/test-with-allure-report.yml

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 13, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mialeska mialeska merged commit d1c20de into master May 13, 2024
9 checks passed
@mialeska mialeska deleted the enhancement/terminate_app branch May 13, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@mialeska mialeska

Labels
enhancement New feature or request
Projects
Aquality Appium Mobile
Status: Done
Template projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mialeska