Draft changes to the io_uring prototype #208
Conversation
for some reason, the linker on my linux machine fails to link the tests otherwise. investigate / fix before merging.
| @@ -1,18 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
This deletion seems probably wrong? Not sure where it came from
|
|
||
| public struct AsyncFileDescriptor: ~Copyable { | ||
| @usableFromInline var open: Bool = true | ||
| @usableFromInline let fileSlot: IORingFileSlot |
There was a problem hiding this comment.
Ideally this should be a borrow of the file slot, but that's hard to express right now
| mode, | ||
| options: options, | ||
| permissions: permissions, | ||
| intoSlot: fileSlot.borrow() |
There was a problem hiding this comment.
This is a hack, this should also be an actual borrow
| ) | ||
| } | ||
|
|
||
| internal init(_ fileSlot: consuming IORingFileSlot, ring: ManagedIORing) { |
There was a problem hiding this comment.
more "should be a borrow"
| } | ||
|
|
||
| @inlinable @inline(__always) | ||
| public consuming func close(isolation actor: isolated (any Actor)? = #isolation) async throws { |
There was a problem hiding this comment.
I want to review the heavy use of isolation parameters at some point, as well as inlinability
| self.isBorrow = isBorrow | ||
| } | ||
|
|
||
| func withResource() { |
Sources/System/IORing.swift
Outdated
| } | ||
|
|
||
| //TODO: this is a workaround for lifetime issues and should be removed | ||
| @usableFromInline func borrow() -> IOResource<T> { |
There was a problem hiding this comment.
This is awful, but it unblocks me for now
| let ringFlags: UInt32 | ||
| let ringDescriptor: Int32 | ||
|
|
||
| @usableFromInline let submissionMutex: Mutex<SQRing> |
There was a problem hiding this comment.
Another dubiously inline thing
| fatalError("failed to unregister files") | ||
| } | ||
|
|
||
| public func getFile() -> IORingFileSlot? { |
There was a problem hiding this comment.
Not clear to me that this is the interface we want, but need to think about it more
| } | ||
|
|
||
| public func submitAndWait(_ request: __owned IORequest, isolation actor: isolated (any Actor)? = #isolation) async -> IOCompletion { | ||
| var consumeOnceWorkaround: IORequest? = request |
There was a problem hiding this comment.
This is working around "can't statically guarantee the closure will only be called once"
| case nop // nothing here | ||
| case openat( | ||
| atDirectory: FileDescriptor, | ||
| path: UnsafePointer<CChar>, |
There was a problem hiding this comment.
path should probably be a FilePath?
No description provided.