Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about bundled protos not needing import SwiftProtobuf. #1525

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

thomasvl
Copy link
Collaborator

No description provided.

@thomasvl thomasvl requested a review from tbkka December 11, 2023 21:24
Copy link
Collaborator

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@thomasvl thomasvl merged commit 498b0b8 into apple:main Dec 11, 2023
9 checks passed
@thomasvl thomasvl deleted the add_bundle_note branch December 11, 2023 21:54
@thomasvl
Copy link
Collaborator Author

@tbkka want me to pull this to 1.x also?

@tbkka
Copy link
Collaborator

tbkka commented Dec 11, 2023

Either way. It's a trivial change, so might be worth bringing over just for general diff-reduction. On the other hand, it's certainly not a critical issue so there's no compelling reason to do extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants