Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A performance-oriented test decoding 1 million messages from a stream #1499

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

tbkka
Copy link
Collaborator

@tbkka tbkka commented Nov 9, 2023

This is inspired by a slow case discovered by the oss-fuzz service, this attempts to decode a stream consisting of a million zero bytes. Each of these zero bytes represents a single message with no non-default fields.

I'm checking this in to help aid in future performance optimization for AsyncMessageSequence.

Checking this in to help aid in future performance optimization for
AsyncMessageSequence
@tbkka tbkka requested review from thomasvl and FranzBusch November 9, 2023 22:57
Copy link
Collaborator

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the only down side is these will slow down all test runs. But having it to eventual do the performance improvements makes some sense.

Also factor out the number of iterations so future
tinkerers have a way to experiment.
@tbkka
Copy link
Collaborator Author

tbkka commented Nov 9, 2023

I cut it back to 100,000 bytes instead of a million. That should reduce the overall impact on test time. I've factored out the number of iterations so future tinkerers can easily experiment.

@tbkka tbkka merged commit a146c4a into apple:main Nov 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants