Adopt Mutex where available #70
Conversation
| private final class _StorageWithMutex: _Storage, @unchecked Sendable { | ||
| let mutex = Mutex<Void>(()) | ||
|
|
||
| override func withLock<Result>(_ body: () throws -> Result) rethrows -> Result { |
There was a problem hiding this comment.
Does this actually compile without warnings under strict concurrency? The closure that Mutex takes is sending whereas ours is not. This should produce a warning/error.
There was a problem hiding this comment.
Needing dynamic dispatch is also a little gnarly.
There was a problem hiding this comment.
I tried .enableExperimentalFeature("StrictConcurrency") and didn't get any errors, but added sending in 948fe6c to be safe.
There was a problem hiding this comment.
I think dynamic dispatch is still better than an extra allocation for the lock?
There was a problem hiding this comment.
Had to revert 948fe6c due to it breaking Swift 5.9/5.10
guoye-zhang
added
🔨 semver/patch
guoye-zhang
force-pushed
the
mutex
branch
2 times, most recently
from
948fe6c to
c82e407
Compare
| @@ -99,7 +109,40 @@ public struct HTTPFields: Sendable, Hashable { | |||
| } | |||
| } | |||
|
|
|||
| private var _storage = _Storage() | |||
| #if canImport(Synchronization) | |||
| @available(macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0, *) | |||
There was a problem hiding this comment.
Not sure how to fix this on Swift 5.9/5.10.
/__w/swift-http-types/swift-http-types/Sources/HTTPTypes/HTTPFields.swift:113:63: error: unrecognized platform name 'visionOS'
@available(macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0, *)
There was a problem hiding this comment.
Fixed by switching to a compiler version check instead of a canImport check.
Mutex should eliminate the extra allocation. Subclassing is the only way I found to work. I tried enums (enum case cannot be unavailable) and class-bound protocols (
isKnownUniquelyReferenceddoesn't work). @FranzBusch