-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+tracing Instrument Invocation handlers using swift-distributed-tracing #1085
base: main
Are you sure you want to change the base?
Conversation
+tracing injector/extractor for tracing and InvocationMessage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
import NIO | ||
import OpenTelemetry | ||
import OtlpGRPCSpanExporting | ||
import Tracing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all these imports needed?
init(actorSystem: ActorSystem) async { | ||
self.actorSystem = actorSystem | ||
|
||
self.receptionID = "*" // default key for "all of this type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the only type that gets registered with the receptionist so it doesn't matter what receptionID
is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*
is by convention the "default key" which we use for "all the actors" #1084
@@ -12,6 +12,7 @@ | |||
// | |||
//===----------------------------------------------------------------------===// | |||
|
|||
import _PrettyLogHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used?
Fully functional, basic, swift-distributed-tracing integration... in just 20 lines of actual changed code (!):
80dd5a5
(#1085)Further, this includes a complete sample app that illustrates this.
Resolves #847 Instrument system with Swift Distributed Tracing
Resolves #476 Context propagation mechanism for actors: Baggage
The
Samples
project contains a full sample that showcases this end-to-end. I'll write some docs for it later, but also intend to include this sample in tracing documentation perhaps?Short version:
We automatically get spans for distributed calls etc 🥳
and