Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Scottmitch committed May 6, 2022
1 parent fdd8b70 commit f452fb1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ public static void main(String... args) throws Exception {
// Using the default value is suitable in most scenarios, but if you want to customize the value
// consider how many resources (network traffic, CPU for local timer management) vs time to detect
// bad connection.
// By default, keep alive is only sent when no traffic is detected, so if both peers have keep alive
// the faster interval will be the primary sender.
// The keep alive is only sent when no traffic is detected, so if both peers have keep alive the
// faster interval will be the primary sender.
h2().keepAlivePolicy(whenIdleFor(ofSeconds(4)))
// Enable frame logging so we can see the PING frames sent/received.
.enableFrameLogging("servicetalk-examples-h2-frame-logger", TRACE, () -> true)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import io.servicetalk.concurrent.api.Single;
import io.servicetalk.grpc.netty.GrpcServers;

import io.grpc.examples.helloworld.StreamingGreeter.StreamingGreeterService;
import io.grpc.examples.keepalive.StreamingGreeter.StreamingGreeterService;

import static io.servicetalk.http.netty.H2KeepAlivePolicies.whenIdleFor;
import static io.servicetalk.http.netty.HttpProtocolConfigs.h2;
Expand All @@ -36,8 +36,8 @@ public static void main(String... args) throws Exception {
// Using the default value is suitable in most scenarios, but if you want to customize the value
// consider how many resources (network traffic, CPU for local timer management) vs time to detect
// bad connection.
// By default, keep alive is only sent when no traffic is detected, so if both peers have keep alive
// the faster interval will be the primary sender.
// The keep alive is only sent when no traffic is detected, so if both peers have keep alive the
// faster interval will be the primary sender.
h2().keepAlivePolicy(whenIdleFor(ofSeconds(6)))
// Enable frame logging so we can see the PING frames sent/received.
.enableFrameLogging("servicetalk-examples-h2-frame-logger", TRACE, () -> true)
Expand Down

0 comments on commit f452fb1

Please sign in to comment.