TLVReader int parsing fixes #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes strange behavior (in C++) and resulting errors when parsing to: uint64_t: 255 << 32 has insufficient space int32_t: 255 << 24 also It leads to uint64_t only being parsed to 32 bit in my case, also int32 being only "int31"s... ASAN pointed out those as errors on the log.
|
need more input on this? I played around further with this, the u/int64 is definitely a bug on all compilers, be it C or C++.... The int32_t: 255 << 24 seems to be a warning of asan, but seems to work anyways... |
badbanks94
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes strange behavior (in C++) and resulting errors when parsing to:
uint64_t: 255 << 32 has insufficient space
int32_t: 255 << 24 also
It leads to uint64_t only being parsed to 32 bit in my case, also int32 being only "int31"s...
ASAN pointed out those as errors on the log.
This is defined behavior in C++ standard but it leads to non-wanted results.