-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(federation): fixed a bug losing __typename
selection in query plan
#6555
base: dev
Are you sure you want to change the base?
Conversation
…me sibling attached
|
@duckki, please consider creating a changeset entry in |
__typename
selection in query paln__typename
selection in query plan
if *trigger < *existing.trigger { | ||
// overwrite if the new trigger is preferable (= less) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to just have a nicely named method here instead of using an overloaded operator that requires a comment at every usage site ^^
CI performance tests
|
Fixed
PathTree::from_paths
to prefer trigger value with a typename sibling attached.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.