Skip to content

Commit

Permalink
a-e-r: Add missing peer dependency on graphql. (#3496)
Browse files Browse the repository at this point in the history
* Adds missing peer dependency

* Widen `peerDependencies` range to match other Apollo packages' ranges.

The `apollo-engine-reporting` package was absolutely missing its
`peerDependencies` specification for `graphql`.  The previous commit added
it, but we also need to expand it to match the same range as suggested by
the rest of the Apollo packages in the Apollo Server monorepo.

Ref: https://git.io/JeXBd

* Add CHANGELOG.md for #3496.
  • Loading branch information
arcanis authored and abernix committed Nov 27, 2019
1 parent c63786b commit a12a0bf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ The version headers in this history reflect the versions of Apollo Server itself
> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the the appropriate changes within that release will be moved into the new section.
- `@apollo/gateway`: Add `@types/node-fetch` as a regular dependency to avoid missing dependency for TypeScript consumers. [PR #3546](https://github.com/apollographql/apollo-server/pull/3546) [Issue #3471](https://github.com/apollographql/apollo-server/issues/3471)
- `apollo-engine-reporting`: Declare acceptable `graphql` versions ranges in `peerDependencies` rather than allowing it to occur implicitly (and less ideally) via its consumers (e.g. most `apollo-server-*` packages). [PR #3496](https://github.com/apollographql/apollo-server/pull/3496)

### v2.9.12

Expand Down
3 changes: 3 additions & 0 deletions packages/apollo-engine-reporting/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,8 @@
"apollo-server-types": "file:../apollo-server-types",
"async-retry": "^1.2.1",
"graphql-extensions": "file:../graphql-extensions"
},
"peerDependencies": {
"graphql": "^0.12.0 || ^0.13.0 || ^14.0.0"
}
}

0 comments on commit a12a0bf

Please sign in to comment.