-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite documentation for custom pagination with field policies #7175
Conversation
Hi Benjamin, Thanks for posting the preview. I'm trying to make sense of it. I'm running into the same issue where I have two separate entries in the cache based on the args. Maybe you could provide guidance? |
8dea866
to
5731c38
Compare
211fdd4
to
88d95b3
Compare
967c321
to
8e78ce3
Compare
@StephenBarlow can you let me know when you're done with your edits? I'll hold off on reviewing until your changes are in. Thanks! |
Disregard @StephenBarlow - I talked to @benjamn and know the plan is to hold off on further edits until after this is merged. |
eecbc19
to
96a2dbe
Compare
@StephenBarlow @hwillson I split the content about |
@benjamn The keyArgs split-out looks good! If you're happy with the content-completeness of these docs, I think we should go ahead and get them out there. I think a steady stream of improvements over the next few weeks will do the trick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great @benjamn!
96a2dbe
to
ad01a34
Compare
This is a long-overdue rewrite of the https://www.apollographql.com/docs/react/data/pagination/ documentation (the first item in #6711), to reflect the new tools that Apollo Client 3 provides.
I welcome your feedback in the form of comments, but I'm not looking for a PR review just yet, because the rewriting is still very much in progress!
Quick link to the deploy preview: https://deploy-preview-7175--apollo-client-docs.netlify.app/docs/react/data/pagination/