Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Router 7 integration #394

Open
wants to merge 65 commits into
base: next
Choose a base branch
from
Open

React Router 7 integration #394

wants to merge 65 commits into from

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Nov 25, 2024

From my side, this works now and I could even circumvent the need for a PR to turbo-stream (although it would be nice if that would have native support for ReadableStream).

There is one outstanding type PR for remix-run/react-router#12264, but I think we can already get this reviewed at this point.

Copy link

pkg-pr-new bot commented Nov 25, 2024

npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-react-streaming@394
npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/experimental-nextjs-app-support@394
npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-integration-react-router@394

commit: b9d20bc

Copy link

relativeci bot commented Nov 25, 2024

#374 Bundle Size — 1.32MiB (+5.83%).

b9d20bc(current) vs c125a08 main#352(baseline)

Note

Bundle removed 1 duplicate package – View changed duplicate packages

Bundle metrics  Change 9 changes Regression 2 regressions Improvement 2 improvements
                 Current
#374
     Baseline
#352
Regression  Initial JS 1.04MiB(+4.22%) 1016.91KiB
No change  Initial CSS 70B 70B
Change  Cache Invalidation 85.18% 24.97%
Change  Chunks 36(+5.88%) 34
Change  Assets 62(+5.08%) 59
Change  Modules 678(+6.6%) 636
Regression  Duplicate Modules 119(+12.26%) 106
Change  Duplicate Code 5.33%(+14.38%) 4.66%
Improvement  Packages 25(-3.85%) 26
Improvement  Duplicate Packages 0(-100%) 1
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#374
     Baseline
#352
Regression  JS 1.31MiB (+5.8%) 1.24MiB
Regression  Other 10.01KiB (+10.12%) 9.09KiB
No change  CSS 70B 70B

Bundle analysis reportBranch pr/react-router-7Project dashboard


Generated by RelativeCIDocumentationReport issue

@phryneas phryneas changed the base branch from pr/multipart-streaming to next January 9, 2025 13:38
@phryneas phryneas changed the base branch from next to pr/multipart-streaming January 9, 2025 13:42
@phryneas phryneas changed the base branch from pr/multipart-streaming to main January 9, 2025 13:51
@phryneas phryneas changed the base branch from main to next January 9, 2025 13:51
@phryneas
Copy link
Member Author

phryneas commented Jan 9, 2025

updated the initial comment, ready for review.

@phryneas phryneas marked this pull request as ready for review January 9, 2025 14:12
@phryneas phryneas requested a review from a team as a code owner January 9, 2025 14:12
@phryneas phryneas changed the title [WIP] React Router 7 integration React Router 7 integration Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants