Added firemaking plugin for Kotlin #349
Conversation
| } | ||
|
|
||
| fun walkCoords(direction: Direction): Position { | ||
| if (direction == Direction.NORTH) { |
There was a problem hiding this comment.
position.step(1, direction))
There was a problem hiding this comment.
That is much simpler, thank you!
No, that's nothing to be sorry about. It's great :-). Will get around to reviewing shortly. |
tlf30
force-pushed
the
kotlin-experiments-firemaking
branch
from
927c273 to
15ba396
Compare
|
This has been rebased and setup for the new build system for kotlin plugins. |
Fix wrong class path
| } | ||
|
|
||
|
|
||
| on { ItemOnItemMessage::class } |
There was a problem hiding this comment.
@Major- didn't you write something in Ruby to handle these ItemOnItem pairs?
There was a problem hiding this comment.
I removed it because it wasn't very good, maybe we could look into something for kotlin
There was a problem hiding this comment.
Is the ItemOnItemMessage not the correct way to do this?
There was a problem hiding this comment.
No this is correct, we're just discussing how we can make it a bit nicer
|
Blocked on item dropping |
|
After Firemaking is merged we're going to freeze |
|
@tlf30 I'm working on the ground item code now. |
|
@ryleykimmel your ground item code is awesome! Once it is merged in I update this. |
garyttierney
force-pushed
the
kotlin-experiments
branch
from
5211b9b to
97896a3
Compare
Hello.
I have ported the firemaking plugin as discussed in #303. This has several fixes in it and I did test it.
The only things I am not sure on are the random equations for a successful chance of lighting the fire and how long the fire should burn.
EDIT: Also, this does not support lighting logs already on the ground because I have no way to test easily until dropping items is implemented. Also does not enforce not lighting fires in banks as I am not sure how to implement that.
Can someone please review.
PS: Yes, I know I have a lot of pull requests open right now. Sorry.
Thank you,
Trevor