Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File check. Issue235 #250

Merged
merged 6 commits into from
Oct 9, 2023
Merged

File check. Issue235 #250

merged 6 commits into from
Oct 9, 2023

Conversation

DanielPerkins7
Copy link
Contributor

resolve #235
I was unsure which files needed to be checked but I think checked the right ones so they are only appended if they are files that exist.

@DanielPerkins7 DanielPerkins7 requested a review from a team as a code owner August 1, 2023 14:59
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 1, 2023
View reviewed changes
ssm/ssm2.py Fixed Show fixed Hide fixed
@tofu-rocketry
Copy link
Member

From dev meeting:

@tofu-rocketry tofu-rocketry self-assigned this Aug 1, 2023
@tofu-rocketry tofu-rocketry added this to the 3.3.1 milestone Sep 18, 2023
@tofu-rocketry tofu-rocketry force-pushed the issue235 branch 2 times, most recently from 6ff87dc to 7d99827 Compare September 18, 2023 15:36
@DanielPerkins7 @tofu-rocketry
Check if item is a file when using directory queue
afe46aa 
This fixes issues with the item count being wrong and whole directories
being passed on to the sender.
@tofu-rocketry
Revert "Check if item is a file when using directory queue"
3fcbb54 
This reverts commit afe46aa as the file
filtering needs to be implmented earlier in the code.
@tofu-rocketry
Add unit test for dir in mess dir issue
132410a
@tofu-rocketry
Filter file list to exclude directories
bc56fd3
@tofu-rocketry
Add underscore to temp dir name to make readable
1defe69 
tempfile creates files and folders with a random name, but adds the
prefix directly before it, so this makes it more readable by separating
those parts.
@tofu-rocketry
Rewrite test to work on Unix
b8a08e6 
Previous version of test failed in Ubuntu Travis environment, possibly
due to the file being kept open in the context manager.
RoseECooper
RoseECooper approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@RoseECooper RoseECooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

RedProkofiev
RedProkofiev approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@RedProkofiev RedProkofiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks snazzy

@tofu-rocketry tofu-rocketry merged commit bf6777f into apel:dev Oct 9, 2023
@tofu-rocketry tofu-rocketry mentioned this pull request Oct 9, 2023
Closed
William-Brown5515 pushed a commit to William-Brown5515/ssm that referenced this pull request Nov 20, 2024
@tofu-rocketry
Merge pull request apel#250 from pjcon/246-no-cloudtype-primary-key
ef5571c 
246 no cloudtype primary key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedProkofiev RedProkofiev RedProkofiev approved these changes

@RoseECooper RoseECooper RoseECooper approved these changes

Assignees

@tofu-rocketry tofu-rocketry

Labels
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

Message directory queue inconsistentcy with sub-directories
4 participants
@DanielPerkins7 @tofu-rocketry @RoseECooper @RedProkofiev