-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2990] Add support for securityContext in the helm charts #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add the same change to the admission controller deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
leaving open for others to comment on the changes
Could defaults be set to match the container images ? |
The values are meant for overrides. If blank they will already default to the container settings. As YuniKorn doesn't read or write any files, the actual values don't really matter much. However, setting security context is convenient in environments where this is required for policy reasons. |
Right. I planned to submit this change for policy reasons (but stopped at the Jira step). Good to have it now 👍 |
I personally would rather not encode this (or any other specific values) into the default helm chart. Security context is something each environment policy differs on. It's not possible to construct one that will satisfy every policy. The default values are already secure; this PR simply allows setting them explicitly if required in certain environments. |
Yes that makes sense. |
What is this PR for?
Add support for various
securityContext
settings in the template.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2990
How should this be tested?
Screenshots (if appropriate)
Questions: