Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2924] [core] Remove occupiedResource handling logic #984

Closed
wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Oct 15, 2024

What is this PR for?

Remove code that deals with occupiedResource.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2924

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Oct 15, 2024
@pbacsko pbacsko marked this pull request as draft October 15, 2024 12:31
@pbacsko pbacsko changed the title [YUNIKORN-2924] [core] Remove occupiedResource handling logic DRAFT [YUNIKORN-2924] [core] Remove occupiedResource handling logic Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (44705ae) to head (2b99742).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #984   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          97       97           
  Lines       12625    12623    -2     
=======================================
- Hits        10290    10289    -1     
- Misses       2052     2053    +1     
+ Partials      283      281    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko marked this pull request as ready for review October 16, 2024 12:02
@pbacsko pbacsko requested a review from wilfred-s October 16, 2024 12:02
@pbacsko pbacsko changed the title DRAFT [YUNIKORN-2924] [core] Remove occupiedResource handling logic [YUNIKORN-2924] [core] Remove occupiedResource handling logic Oct 16, 2024
@pbacsko
Copy link
Contributor Author

pbacsko commented Oct 16, 2024

Note: e2e tests has passed w/o go.mod/go.sum update.

Copy link
Contributor

@manirajv06 manirajv06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@pbacsko pbacsko closed this in 079a02d Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants