Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2848] Refactor preemption_queue_test.go #983

Closed
wants to merge 8 commits into from

Conversation

ryankert01
Copy link
Contributor

What is this PR for?

Refactor TestGetPreemptableResource test based on variables and syntax constructs used in TestGetRemainingGuaranteedResource.

For example, variables defined for test resources like res1, res2 etc and t.Run({})

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2848

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.29%. Comparing base (44705ae) to head (fa7cb88).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   81.50%   81.29%   -0.21%     
==========================================
  Files          97       97              
  Lines       12625    15463    +2838     
==========================================
+ Hits        10290    12571    +2281     
- Misses       2052     2611     +559     
+ Partials      283      281       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

pkg/scheduler/objects/preemption_queue_test.go Outdated Show resolved Hide resolved
pkg/scheduler/objects/preemption_queue_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@ryankert01 ryankert01 deleted the YUNIKORN-2848 branch October 28, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants