-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2848] Refactor preemption_queue_test.go #983
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 81.50% 81.29% -0.21%
==========================================
Files 97 97
Lines 12625 15463 +2838
==========================================
+ Hits 10290 12571 +2281
- Misses 2052 2611 +559
+ Partials 283 281 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
What is this PR for?
Refactor TestGetPreemptableResource test based on variables and syntax constructs used in TestGetRemainingGuaranteedResource.
For example, variables defined for test resources like res1, res2 etc and t.Run({})
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2848
How should this be tested?
Screenshots (if appropriate)
Questions: