Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2118] Add smoke test for event streaming #705

Closed
wants to merge 2 commits into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Nov 8, 2023

What is this PR for?

The PR updates TestApplicationHistoryTracking with streaming events. Both the batch and streaming interface is checked to make sure they are in sync.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2118

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Nov 8, 2023
@pbacsko pbacsko marked this pull request as draft November 8, 2023 12:33
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (681a4cb) 77.90% compared to head (7509840) 78.27%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #705      +/-   ##
==========================================
+ Coverage   77.90%   78.27%   +0.37%     
==========================================
  Files          85       84       -1     
  Lines       13834    13817      -17     
==========================================
+ Hits        10777    10815      +38     
+ Misses       2724     2673      -51     
+ Partials      333      329       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko force-pushed the YUNIKORN-2118 branch 2 times, most recently from 3b4e52e to aa0ce5d Compare December 22, 2023 01:38
@pbacsko pbacsko requested a review from manirajv06 January 24, 2024 11:17
@pbacsko pbacsko marked this pull request as ready for review January 24, 2024 11:17
@pbacsko pbacsko changed the title [WIP][YUNIKORN-2118] Add smoke test for event streaming [YUNIKORN-2118] Add smoke test for event streaming Jan 24, 2024
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the file restclient.go to restclient_test.go ? None of the content should be needed outside of the scheduler tests.

Beside that changes look good

@pbacsko pbacsko requested a review from wilfred-s February 1, 2024 10:51
Copy link
Contributor

@zhuqi-lucas zhuqi-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbacsko pbacsko deleted the YUNIKORN-2118 branch April 28, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants