-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2118] Add smoke test for event streaming #705
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 77.90% 78.27% +0.37%
==========================================
Files 85 84 -1
Lines 13834 13817 -17
==========================================
+ Hits 10777 10815 +38
+ Misses 2724 2673 -51
+ Partials 333 329 -4 ☔ View full report in Codecov by Sentry. |
3b4e52e
to
aa0ce5d
Compare
aa0ce5d
to
c3e4151
Compare
c3e4151
to
90b19c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename the file restclient.go
to restclient_test.go
? None of the content should be needed outside of the scheduler tests.
Beside that changes look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
The PR updates
TestApplicationHistoryTracking
with streaming events. Both the batch and streaming interface is checked to make sure they are in sync.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2118
How should this be tested?
Screenshots (if appropriate)
Questions: