[YUNIKORN-2085] CurrentPriority field missing from Queues API respons… #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e when pedding application exists
makinyemi
pushed a commit
to makinyemi/yunikorn-core
that referenced
this pull request
Nov 8, 2023
…es API (apache#700) Closes: apache#700 Signed-off-by: Craig Condit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The
CurrentPriorityfield is currently tagged with "omitempty", which causes it to be omitted from json response when the value is 0.Omitting the field in this case could mislead consumers or cause potential errors when consuming the API, such as throwing exceptions upon finding the expected field missing from the response.
Removing omitempty ensures the field will always be included with its actual value, even if 0. This avoids situations where the field might be missing.
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-2085