-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21 #46
Conversation
- Remove the copy of ASM - Add project 'plastic-asm' to be the shadowed version of ASM 9.6 - Add a version property for ASM in the build
- Inject a Tapestry specific TapestryAnnotationNode into ASM to get access to the static helper instead of relying on reflection
Adjusted to inject a Tapestry specific class into the relocated ASM package in order to gain access to the package-protected static helper instead of using reflection |
Thank you so much, @chrispoulsen and @cpoulsen-dezide (both profiles committed, so I thank both, even if they're the same person! 😄 ) |
When will this be released ? I am itching to try some Java 21 things on a project that uses Tapestry IOC |
Hello, @chrispoulsen ! Were you able to open the Tapestry subprojects without compilation errors in Eclipse with your branch? The Plastic project cannot find any of the package-relocated ASM classes after that and I'm unable to do any development. Cheers! |
Me again. I've just managed to get the Tapestry project working again in Eclipse with some half-arcane Gradle stuff. :) |
I'm using IntelliJ IDEA and had no issues. |
* TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21 - Remove the copy of ASM - Add project 'plastic-asm' to be the shadowed version of ASM 9.6 - Add a version property for ASM in the build * TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21 - Inject a Tapestry specific TapestryAnnotationNode into ASM to get access to the static helper instead of relying on reflection --------- Co-authored-by: Chris Poulsen <[email protected]>
Bits for https://issues.apache.org/jira/browse/TAP5-2769 feel free to use directly or use as inspiration.
Changes include: