Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21 #46

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

chrispoulsen
Copy link
Contributor

Bits for https://issues.apache.org/jira/browse/TAP5-2769 feel free to use directly or use as inspiration.

Changes include:

  • Remove the copy of ASM
  • Add project 'plastic-asm' to be the shadowed version of ASM 9.6 (using gradle shadow plugin)
  • Add a version property for ASM in the build

- Remove the copy of ASM
- Add project 'plastic-asm' to be the shadowed version of ASM 9.6
- Add a version property for ASM in the build
- Inject a Tapestry specific TapestryAnnotationNode into ASM to get access to the static helper instead of relying on reflection
@chrispoulsen chrispoulsen marked this pull request as draft November 13, 2023 22:30
@chrispoulsen
Copy link
Contributor Author

chrispoulsen commented Nov 13, 2023

Adjusted to inject a Tapestry specific class into the relocated ASM package in order to gain access to the package-protected static helper instead of using reflection

@chrispoulsen chrispoulsen marked this pull request as ready for review November 14, 2023 08:19
@thiagohp
Copy link
Contributor

thiagohp commented Dec 1, 2023

Thank you so much, @chrispoulsen and @cpoulsen-dezide (both profiles committed, so I thank both, even if they're the same person! 😄 )

@thiagohp thiagohp merged commit ecb81b8 into apache:master Dec 2, 2023
3 checks passed
@hrgdavor
Copy link

When will this be released ? I am itching to try some Java 21 things on a project that uses Tapestry IOC

@thiagohp
Copy link
Contributor

Hello, @chrispoulsen !

Were you able to open the Tapestry subprojects without compilation errors in Eclipse with your branch? The Plastic project cannot find any of the package-relocated ASM classes after that and I'm unable to do any development.

Cheers!

@thiagohp
Copy link
Contributor

Me again. I've just managed to get the Tapestry project working again in Eclipse with some half-arcane Gradle stuff. :)

@chrispoulsen
Copy link
Contributor Author

Hello, @chrispoulsen !

Were you able to open the Tapestry subprojects without compilation errors in Eclipse with your branch? The Plastic project cannot find any of the package-relocated ASM classes after that and I'm unable to do any development.

I'm using IntelliJ IDEA and had no issues.

derkoe pushed a commit to derkoe/tapestry-5 that referenced this pull request Jul 2, 2024
* TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21

- Remove the copy of ASM
- Add project 'plastic-asm' to be the shadowed version of ASM 9.6
- Add a version property for ASM in the build

* TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21

- Inject a Tapestry specific TapestryAnnotationNode into ASM to get access to the static helper instead of relying on reflection

---------

Co-authored-by: Chris Poulsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants