fix: remove sort values on stacked totals #31333
Open
+170
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
force-pushed
the
elizabeth/fix-stacked-totals
branch
2 times, most recently
from
215661b to
e685c5d
Compare
superset-frontend/webpack.config.js
Outdated
| @@ -568,7 +568,7 @@ if (isDevMode) { | |||
| warnings: false, | |||
| runtimeErrors: error => !/ResizeObserver/.test(error.message), | |||
| }, | |||
| logging: 'error', | |||
| logging: 'verbose', | |||
There was a problem hiding this comment.
thanks for catching.. no that was just for testing.
eschutho
force-pushed
the
elizabeth/fix-stacked-totals
branch
3 times, most recently
from
33390fb to
a3084fc
Compare
eschutho
force-pushed
the
elizabeth/fix-stacked-totals
branch
2 times, most recently
from
c860ef7 to
e0efdfc
Compare
eschutho
requested review from
sadpandajoe,
geido,
rusackas and
betodealmeida
as code owners
|
/testenv up |
eschutho
force-pushed
the
elizabeth/fix-stacked-totals
branch
3 times, most recently
from
2e38e59 to
5e87689
Compare
eschutho
force-pushed
the
elizabeth/fix-stacked-totals
branch
from
5e87689 to
9fd7f26
Compare
kgabryje
reviewed
Jan 21, 2025
|
|
||
| const metricMapFunc = (metric: string | AdhocMetric) => { | ||
| if (metric.hasOwnProperty('label')) { | ||
| return (metric as AdhocMetric).label; |
There was a problem hiding this comment.
I think we already have a util getMetricLabel for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a y axis sort is selected with a stacked bar chart with totals shown, the y axis column value was being added to the total. This pr checks that only the metrics are being used in calculating totals by passing in the list of metrics labels to the total calculation function, and only totaling the columns that are metrics, not the ones used in sorting.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Create a chart with one metric, and a sort value. Turn on stacked and show values. The sort value column should not be added to the total of the metric.
ADDITIONAL INFORMATION