refactor(sqllab): migrate share queries via kv by permalink

[justinpark]

SUMMARY

This PR changes the existing SHARE_QUERIES_VIA_KV_STORE feature to store data using the permalink API instead of the KV store. This is one of the prerequisites of Remove old KV store endpoint and its associated asset.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after--permalink2.mov

TESTING INSTRUCTIONS

Go to SQL Lab and then click "Copy Link"

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Attention: Patch coverage is 87.74194% with 19 lines in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (76d897e) to head (45e570b).
Report is 1334 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/commands/sql_lab/permalink/get.py	70.27%	11 Missing ⚠️
superset/sqllab/permalink/api.py	90.19%	5 Missing ⚠️
superset/commands/sql_lab/permalink/create.py	88.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #29163       +/-   ##
===========================================
+ Coverage   60.48%   83.45%   +22.97%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39249    -36987     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32757    -13357     
+ Misses      28017     6492    -21525     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.84% <67.74%> (-0.32%)	⬇️
javascript	?
mysql	76.03% <87.74%> (?)
postgres	76.09% <87.74%> (?)
presto	53.34% <67.74%> (-0.46%)	⬇️
python	83.45% <87.74%> (+19.97%)	⬆️
sqlite	75.57% <87.74%> (?)
unit	61.06% <67.74%> (+3.44%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[villebro]

/testenv up

[github-actions]

@villebro Ephemeral environment spinning up at http://52.37.81.73:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[villebro]

/testenv up FEATURE_SHARE_QUERIES_VIA_KV_STORE=true

[github-actions]

@villebro Ephemeral environment spinning up at http://35.86.167.107:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[villebro]

Great improvement, this is long overdue! I suggest removing the SHARE_QUERIES_VIA_KV_STORE feature flag, and making the permalink only store the selected portion of the editor. Other than that this looks great!

[michael-s-molina]

I suggest removing the SHARE_QUERIES_VIA_KV_STORE feature flag, and making the permalink only store the selected portion of the editor.

@villebro There's a proposal in 5.0 to remove this feature flag.

[justinpark]

@villebro @michael-s-molina could you take a look?

[michael-s-molina]

Can you add support for old saved query URLs?

[justinpark]

Can you add support for old saved query URLs?

Done. @michael-s-molina PTAL

[michael-s-molina]

Did you forget to remove the SHARE_QUERIES_VIA_KV_STORE and KV_STORE from this document?

[michael-s-molina]

LGTM. Thanks for addressing the comments @justinpark!

[LevisNgigi]

Hey, @justinpark I just fetched this to local and when I try to copy the link in Sqllab i get the error, "Request URL:
http://localhost:9000/api/v1/sqllab/permalink
Request Method:
POST
Status Code:
403 FORBIDDEN" could I be missing something? I'm logged in as an admin user.Though after commenting out the @Protect decorator it copies.